Skip to content

Commit

Permalink
BE Put local SignedValueHandler into anonymous namespace to avoid sha…
Browse files Browse the repository at this point in the history
…dowing

Reviewed By: Orvid

Differential Revision: D51939415

fbshipit-source-id: 63703ae18fb776481e26f113e99facc720a9d231
  • Loading branch information
Daniel Rolf authored and facebook-github-bot committed Dec 11, 2023
1 parent c621748 commit 48d6690
Showing 1 changed file with 4 additions and 0 deletions.
4 changes: 4 additions & 0 deletions folly/Conv.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -463,6 +463,8 @@ template Expected<float, ConversionCode> str_to_floating<float>(
template Expected<double, ConversionCode> str_to_floating<double>(
StringPiece* src) noexcept;

namespace {

/**
* This class takes care of additional processing needed for signed values,
* like leading sign character and overflow checks.
Expand Down Expand Up @@ -530,6 +532,8 @@ class SignedValueHandler<T, false> {
Expected<T, ConversionCode> finalize(T value) { return value; }
};

} // namespace

/**
* String represented as a pair of pointers to char to signed/unsigned
* integrals. Assumes NO whitespace before or after, and also that the
Expand Down

0 comments on commit 48d6690

Please sign in to comment.