[flow] Use File_url.create and File_url.parse for document paste protocol
#9248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…protocol Summary: This is a followup of D68132119. The scheme doesn't work for windows paths. This diff replaces it with `File_url.create` and `File_url.parse` pair (which is the underlying uri to file_key conversion code used everywhere else) so that the test can also succeed on windows. Changelog: [internal] Differential Revision: D68233875
|
This pull request was exported from Phabricator. Differential Revision: D68233875 |
|
This pull request has been merged in 9823d65. |
facebook-github-bot
pushed a commit
that referenced
this pull request
Jan 16, 2025
…protocol (#9248) Summary: Pull Request resolved: #9248 This is a followup of D68132119. The scheme doesn't work for windows paths. This diff replaces it with `File_url.create` and `File_url.parse` pair (which is the underlying uri to file_key conversion code used everywhere else) so that the test can also succeed on windows. Changelog: [internal] Reviewed By: gkz Differential Revision: D68233875 ------------------------------------------------------------------------ (from bf8397be9eb23f172fd1565ed98616e49c18d85f) fbshipit-source-id: 37f28345b9e4b45ed766f9cd41a96c22dab8b270
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This is a followup of D68132119. The scheme doesn't work for windows paths. This diff replaces it with
File_url.createandFile_url.parsepair (which is the underlying uri to file_key conversion code used everywhere else) so that the test can also succeed on windows.Changelog: [internal]
Differential Revision: D68233875