Update types in node API: child_processes #2567
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glennreyes
force-pushed
the
node-child-processes
branch
from
3a78e21 to
dbce552
Compare
glennreyes
force-pushed
the
node-child-processes
branch
from
dbce552 to
ea9c1f7
Compare
mroch
added
the
Library definitions
glennreyes
force-pushed
the
node-child-processes
branch
from
ea9c1f7 to
a8e6f02
Compare
Closed
|
Thanks for the contribution and sorry for the delay! I'll rerecord the tests and get this reviewed & merged ASAP! |
|
@gabelevi has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
|
This is great, btw! Thanks a ton for doing this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates all the types of node's
child_processto the current supported node API's (v4+).