Properly restore protections for iOS 13 #66
Merged
+37
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The original protection may have been read/write, not just read-only. Read it & restore it.
This was referenced Aug 22, 2019
amonshiz
approved these changes
Aug 22, 2019
megCanicalKb
pushed a commit
to facebook/FBRetainCycleDetector
that referenced
this pull request
Aug 23, 2019
The original protection may have been read/write, not just read-only. Read it & restore it. Syncing with facebook/fishhook#66
fengjixuchui
added a commit
to fengjixuchui/fishhook
that referenced
this pull request
Sep 26, 2019
Merge pull request facebook#66 from swolchok/master
GLinnik21
reviewed
Oct 9, 2019
| if (isDataConst) { | ||
| oldProtection = get_protection(rebindings); |
There was a problem hiding this comment.
@swolchok why do you get protection of the page of the struct rebindings_entry?
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original protection may have been read/write, not just read-only. Read it & restore it.