Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Also rebind symbols in __DATA_CONST segment #12

Merged
merged 1 commit into from
Jul 30, 2015
Merged

Also rebind symbols in __DATA_CONST segment #12

merged 1 commit into from
Jul 30, 2015

Conversation

mringwal
Copy link
Contributor

No description provided.

@facebook-github-bot
Copy link
Contributor

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at [email protected]. Thanks!

@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@grp
Copy link
Contributor

grp commented Jul 30, 2015

Thanks @mringwal ;)

grp added a commit that referenced this pull request Jul 30, 2015
@grp
Merge pull request #12 from mringwal/master
9086d2f 
Also rebind symbols in __DATA_CONST segment
@grp grp merged commit 9086d2f into facebook:master Jul 30, 2015
@jevinskie
Copy link

Should this cover the new __DATA_DIRTY segment too?

@mringwal
Copy link
Contributor Author

I only looked at UIKit calling into BackBoardServices. There, all lazy symbols have been in __DATA_CONST. I've only added that to be on the safe side. Other than that, I would suggest to just patch all with "__DATA*" :)

@kastiglione kastiglione mentioned this pull request Sep 28, 2015
Closed
@akq41 akq41 mentioned this pull request Jan 18, 2016
Closed
@jobsyu jobsyu mentioned this pull request Jun 18, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mringwal @facebook-github-bot @grp @jevinskie