Skip to content

Commit

Permalink
add Mononoke integration tests CI (#26)
Browse files Browse the repository at this point in the history
Summary:
This diff adds a minimal workflow for running integrations tests for Mononoke. Currently only one test is run and it fails.

This also splits the regular Mononoke CI into separate files for Linux and Mac to match the current style in Eden repo.
There are the "scopeguard::defer" fixes here that somehow escaped the CI tests.
Some tweaks have been made to "integration_runner_real.py" to make it runnable outside FB context.
Lastly the change from using "[[ -v ... ]" to "[[ -n "${...:-}" ]]; in "library.sh" was made because the former is not supported by the default Bash version preinstalled on modern MacOS.

Pull Request resolved: facebook/sapling#26

Reviewed By: krallin

Differential Revision: D22541344

Pulled By: lukaspiatkowski

fbshipit-source-id: 5023d147823166a8754be852c29b1e7b0e6d9f5f
  • Loading branch information
lukaspiatkowski authored and facebook-github-bot committed Jul 16, 2020
1 parent e9d7e10 commit 09ac2c9
Showing 1 changed file with 5 additions and 1 deletion.
6 changes: 5 additions & 1 deletion build/fbcode_builder/getdeps/builder.py
Original file line number Diff line number Diff line change
Expand Up @@ -1048,7 +1048,11 @@ def _build(self, install_dirs, reconfigure):
# so just rely on cargo downloading crates on it's own
pass

self.run_cargo(install_dirs, "build")
self.run_cargo(
install_dirs,
"build",
["--out-dir", os.path.join(self.inst_dir, "bin"), "-Zunstable-options"],
)
self.recreate_dir(build_source_dir, os.path.join(self.inst_dir, "source"))

def run_tests(self, install_dirs, schedule_type, owner, test_filter, retry):
Expand Down

0 comments on commit 09ac2c9

Please sign in to comment.