-
-
Notifications
You must be signed in to change notification settings - Fork 8.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(deployment): add GITHUB_TOKEN permission info... #9373
docs(deployment): add GITHUB_TOKEN permission info... #9373
Conversation
when I set up a new docusaurus repo and following the GitHub Pages deployment guide with GitHub Actions, I ran into the issue, that the automatic token has read only access per default in order to help new users I added information to the guide, so other users don't have to figure it out on their own
✅ [V2]Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
⚡️ Lighthouse report for the deploy preview of this PR
|
https://github.com/peaceiris/actions-gh-pages#%EF%B8%8F-first-deployment-with-github_token ![]() Are you sure that you followed our instructions properly? If you did, please create a repro showing the GH pages deployment failing despite using the recommended config. |
Hi @slorber, thank you for taking the time to have a look into and answering with much details :) 👍 I used the deploy.yml from the current version (2.4.3) -> https://docusaurus.io/docs/deployment#triggering-deployment-with-github-actions In the next / canary version I see indeed the permissions section like in your screenshot. In the 2.4.3 it is not there yet. I reverted the token permissions to the default state and added the permissions section to my action yml and it is working. So my issue is already solved in the next version and I close this PR. |
Thanks If you want you can add the Yaml permission to the v2.4.3 docs, didn't see it wasn't there and it would help others as well. |
Hi @slorber , Good idea! Will do. I didn't know that it is ok to modify the current version. But in this case the addition also works with 2.4.3, so it's a good idea to do. |
Pre-flight checklist
Motivation
When I set up a new docusaurus repo and following the GitHub Pages deployment guide with GitHub Actions, I ran into the issue, that the automatic token has read only access per default.
In order to help new users I added information to the guide, so other users don't have to figure it out on their own
Test Plan
no code change, only mdx
Test links
https://deploy-preview-9373--docusaurus-2.netlify.app/docs/deployment#triggering-deployment-with-github-actions
http://localhost:3000/docs/deployment#triggering-deployment-with-github-actions
New details box "GITHUB_TOKEN permissions"
Related issues/PRs