fix(content-blog): links in feed should be absolute

packages/docusaurus-plugin-content-blog/package.json

@@ -30,6 +30,7 @@
     "fs-extra": "^11.1.1",
     "lodash": "^4.17.21",
     "reading-time": "^1.5.0",
+    "srcset": "^4.0.0",
     "tslib": "^2.6.0",
     "unist-util-visit": "^2.0.3",
     "utility-types": "^3.10.0",

packages/docusaurus-plugin-content-blog/src/__tests__/index.test.ts

@@ -325,29 +325,32 @@ describe('blog plugin', () => {
   it('builds simple website blog with localized dates', async () => {
     const siteDir = path.join(__dirname, '__fixtures__', 'website');
     const blogPostsFrench = await getBlogPosts(siteDir, {}, getI18n('fr'));
-    expect(blogPostsFrench).toHaveLength(9);
+    expect(blogPostsFrench).toHaveLength(10);
     expect(blogPostsFrench[0]!.metadata.formattedDate).toMatchInlineSnapshot(
-      `"6 mars 2021"`,
+      `"23 juillet 2023"`,
     );
     expect(blogPostsFrench[1]!.metadata.formattedDate).toMatchInlineSnapshot(
-      `"5 mars 2021"`,
+      `"6 mars 2021"`,
     );
     expect(blogPostsFrench[2]!.metadata.formattedDate).toMatchInlineSnapshot(
-      `"16 août 2020"`,
+      `"5 mars 2021"`,
     );
     expect(blogPostsFrench[3]!.metadata.formattedDate).toMatchInlineSnapshot(
-      `"15 août 2020"`,
+      `"16 août 2020"`,
     );
     expect(blogPostsFrench[4]!.metadata.formattedDate).toMatchInlineSnapshot(
-      `"27 février 2020"`,
+      `"15 août 2020"`,
     );
     expect(blogPostsFrench[5]!.metadata.formattedDate).toMatchInlineSnapshot(
       `"27 février 2020"`,
     );
     expect(blogPostsFrench[6]!.metadata.formattedDate).toMatchInlineSnapshot(
-      `"2 janvier 2019"`,
+      `"27 février 2020"`,
     );
     expect(blogPostsFrench[7]!.metadata.formattedDate).toMatchInlineSnapshot(
+      `"2 janvier 2019"`,
+    );
+    expect(blogPostsFrench[8]!.metadata.formattedDate).toMatchInlineSnapshot(
       `"1 janvier 2019"`,
     );
   });
@@ -377,7 +380,7 @@ describe('blog plugin', () => {
       expect(blogPost.metadata.editUrl).toEqual(hardcodedEditUrl);
     });
 
-    expect(editUrlFunction).toHaveBeenCalledTimes(9);
+    expect(editUrlFunction).toHaveBeenCalledTimes(10);
 
     expect(editUrlFunction).toHaveBeenCalledWith({
       blogDirPath: 'blog',

packages/docusaurus-plugin-content-blog/src/feed.ts

@@ -9,6 +9,7 @@ import path from 'path';
 import fs from 'fs-extra';
 import logger from '@docusaurus/logger';
 import {Feed, type Author as FeedAuthor} from 'feed';
+import {parse, stringify} from 'srcset';
 import {normalizeUrl, readOutputHTMLFile} from '@docusaurus/utils';
 import {blogPostContainerID} from '@docusaurus/utils-common';
 import {load as cheerioLoad} from 'cheerio';
@@ -106,6 +107,31 @@ async function defaultCreateFeedItems({
       const $ = cheerioLoad(content);
 
       const link = normalizeUrl([siteUrl, permalink]);
+
+      $(`div#${blogPostContainerID} a, div#${blogPostContainerID} img`).each(
+        (_, elm) => {
+          if (elm.tagName === 'a') {
+            const {href} = elm.attribs;
+            if (href) {
+              elm.attribs.href = String(new URL(href, link));
+            }
+          } else if (elm.tagName === 'img') {
+            const {src, srcset} = elm.attribs;
+            if (src) {
+              elm.attribs.src = String(new URL(src, link));
+            }
+            if (srcset) {
+              elm.attribs.srcset = stringify(
+                parse(srcset).map((props) => ({
+                  ...props,
+                  url: String(new URL(props.url, link)),
+                })),
+              );
+            }
+          }
+        },
+      );
+
       const feedItem: BlogFeedItem = {
         title: metadataTitle,
         id: link,

project-words.txt

@@ -152,6 +152,7 @@ jodyheavener
 joshcena
 jscodeshift
 jssdk
+juillet
 kaszubowski
 katex
 kato

website/_dogfooding/_blog tests/2023-07-19-a.mdx

@@ -0,0 +1,9 @@
+---
+title: 'Test if href in feed resolved correctly'
+---
+
+[absolute full url](https://github.com/facebook/docusaurus)
+
+[absolute url with implicit domain name](/tests/blog/2023/07/19/b)
+
+[relative url](2023-07-19-b.mdx)

website/_dogfooding/_blog tests/2023-07-19-b.mdx

@@ -0,0 +1 @@
+# Test Relative Path

yarn.lock

@@ -15367,6 +15367,11 @@ sprintf-js@~1.0.2:
   resolved "https://registry.yarnpkg.com/sprintf-js/-/sprintf-js-1.0.3.tgz#04e6926f662895354f3dd015203633b857297e2c"
   integrity sha512-D9cPgkvLlV3t3IzL0D0YLvGA9Ahk4PcvVwUbN0dSGr1aP0Nrt4AEnTUbuGvquEC0mA64Gqt1fzirlRs5ibXx8g==
 
+srcset@^4.0.0:
+  version "4.0.0"
+  resolved "https://registry.yarnpkg.com/srcset/-/srcset-4.0.0.tgz#336816b665b14cd013ba545b6fe62357f86e65f4"
+  integrity sha512-wvLeHgcVHKO8Sc/H/5lkGreJQVeYMm9rlmt8PuR1xE31rIuXhuzznUUqAt8MqLhB3MqJdFzlNAfpcWnxiFUcPw==
+
 [email protected], ssri@^9.0.0:
   version "9.0.1"
   resolved "https://registry.yarnpkg.com/ssri/-/ssri-9.0.1.tgz#544d4c357a8d7b71a19700074b6883fcb4eae057"