refactor(core): detect if codegen should quote property without using eval() #8045
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Josh-Cena
added
the
pr: internal
Josh-Cena
changed the title
✅ [V2]
To edit notification comments on pull requests, go to your Netlify site settings. |
⚡️ Lighthouse report for the deploy preview of this PR
|
|
Size Change: 0 B Total Size: 813 kB ℹ️ View Unchanged
|
slorber
reviewed
Sep 7, 2022
| })(propName); | ||
| // Escape quotes as well | ||
| const key = shouldQuote ? JSON.stringify(propName) : propName; | ||
| const isIdentifier = |
There was a problem hiding this comment.
what about the test 😅 not really confident it works here, but it looks like it does
There was a problem hiding this comment.
We already have decent tests for this, plus this is a direct translation of the spec, so I won't worry about it too much.
slorber
pushed a commit
that referenced
this pull request
Sep 7, 2022
… eval() (#8045) refactor(core): detect if should quote property when codegen without using eval()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pre-flight checklist
Motivation
Split out from #7993
Test Plan
Test links
Deploy preview: https://deploy-preview-_____--docusaurus-2.netlify.app/
Related issues/PRs