refactor(theme-common): mark package as ESM #6899
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Josh-Cena
added
the
pr: maintenance
|
Fair, sounds like a future problem to worry about 😄 |
slorber
reviewed
Mar 11, 2022
| @@ -8,6 +8,8 @@ | |||
| "build": "node copyUntypedFiles.mjs && tsc", | |||
| "watch": "node copyUntypedFiles.mjs && tsc --watch" | |||
| }, | |||
| "type": "module", | |||
| "sideEffects": false, | |||
There was a problem hiding this comment.
does this thing produce failures alone?
It's something I wanted to test too, as it could help with tree shaking and code splitting
There was a problem hiding this comment.
Ah, sideEffects is good. I can send another PR to add it if it's worth it. Forgot there's an unrelated change here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
To allow Jest to understand imports from this package as ESM. #6520
Have you read the Contributing Guidelines on pull requests?
Yes