feat(v2): make sidebar collapsible #1817
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for docusaurus-2 ready! Built with commit e975f38 |
|
Deploy preview for docusaurus-preview ready! Built with commit e975f38 |
endiliey
approved these changes
Oct 9, 2019
There was a problem hiding this comment.
For some host like netlify, the first page load appends a trailing slash at the end / which causes some weird behavior.
For example, when we go to https://deploy-preview-1817--docusaurus-2.netlify.com/docs/introduction and then click on another category sidebar link, you can notice that it still highlight the inactive category.
Anyway, I've patched the PR a bit. Should be fine now,
|
Need update changelog |
|
Thanks for helping to fix the issue! I simplified the code a bit to remove the trailing slash regardless. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
For docs with a long menu (like Docusaurus and CRA), collapsing the sidebars by default will be more helpful. Thanks to the awesome sidebar metadata refactoring by @endiliey, this is now possible.
Features:
I also removed displaying a smaller + different color link on the level 3, I think we don't need that differentiation now that we have the chevron.
Have you read the Contributing Guidelines on pull requests?
Yes
Test Plan
Load the Netlify preview and click around!
Related PRs
#1815