Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

There is no clearall Button in Show #9224

Closed
2 tasks done
biplavmz opened this issue Aug 14, 2023 · 5 comments · Fixed by #9233
Closed
2 tasks done

There is no clearall Button in Show #9224

biplavmz opened this issue Aug 14, 2023 · 5 comments · Fixed by #9233
Labels
documentation The issue is related to the documentation of Docusaurus status: accepting pr This issue has been accepted, and we are looking for community contributors to implement this

Comments

@biplavmz
Copy link
Contributor

Have you read the Contributing Guidelines on issues?

Description

image

there is no clear all button in the showcase page. as if user want to remove all the selected tags at once he should have clear all button to remove all tags at one click

I would like to add this feature.

Has this been requested on Canny?

No response

Motivation

if user want to remove all the selected tags at once he should have clear all button

API design

No response

Have you tried building it?

No response

Self-service

  • I'd be willing to contribute this feature to Docusaurus myself.
@biplavmz biplavmz added feature This is not a bug or issue with Docusausus, per se. It is a feature request for the future. status: needs triage This issue has not been triaged by maintainers labels Aug 14, 2023
@Josh-Cena
Copy link
Collaborator

I'm okay to have a "reset" button to clear all queries.

@Josh-Cena Josh-Cena added documentation The issue is related to the documentation of Docusaurus status: accepting pr This issue has been accepted, and we are looking for community contributors to implement this and removed feature This is not a bug or issue with Docusausus, per se. It is a feature request for the future. status: needs triage This issue has not been triaged by maintainers labels Aug 14, 2023
@pinakipb2
Copy link
Contributor

@Josh-Cena Have a look at the PR.
Thanks !

@pinakipb2
Copy link
Contributor

pinakipb2 commented Aug 17, 2023

Thanks @slorber for not considering my PR where I had to go through code to fix it first.
Peace 🤘

@slorber
Copy link
Collaborator

slorber commented Aug 17, 2023

@pinakipb2 sorry but please don't assume any malice behind this: I'm simply busy and didn't see there were 2 PRs

Also the author of the issue checked this so it's fair to give them priority unless they don't send a PR in the upcoming days:

CleanShot 2023-08-17 at 10 51 39@2x

@pinakipb2
Copy link
Contributor

pinakipb2 commented Aug 17, 2023 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation The issue is related to the documentation of Docusaurus status: accepting pr This issue has been accepted, and we are looking for community contributors to implement this
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants