Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add bootstrap 4 #4495

Closed
wants to merge 1 commit into from
Closed

add bootstrap 4 #4495

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions packages/react-scripts/template/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -846,20 +846,21 @@ You don’t have to use [React Bootstrap](https://react-bootstrap.github.io) tog
Install React Bootstrap and Bootstrap from npm. React Bootstrap does not include Bootstrap CSS so this needs to be installed as well:

```sh
npm install --save react-bootstrap bootstrap@3
npm install bootstrap@4
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This contradicts the line above, which says "Install React Bootstrap and Bootstrap from npm" (not just install Bootstrap). To use Bootstrap 4 (which is not yet supported by React Bootstrap), reactstrap is a popular option.

Copy link
Contributor

@nickserv nickserv May 28, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be great to recommend Reactstrap for now.

```

Alternatively you may use `yarn`:

```sh
yarn add react-bootstrap bootstrap@3
yarn add bootstrap@4.0.0-alpha.6
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why alpha?

```

Import Bootstrap CSS and optionally Bootstrap theme CSS in the beginning of your ```src/index.js``` file:

```js
import 'bootstrap/dist/css/bootstrap.css';
import 'bootstrap/dist/css/bootstrap-theme.css';
import 'bootstrap/dist/css/bootstrap-grid.css';
import 'bootstrap/dist/css/bootstrap-reboot.css';
// Put any other imports below so that CSS from your
// components takes precedence over default styles.
```
Expand Down