Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[react-scripts] Do not lint *.bs.js files, generated by BuckleScript #3714

Closed
wants to merge 1 commit into from
Closed

[react-scripts] Do not lint *.bs.js files, generated by BuckleScript #3714

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion packages/react-scripts/config/webpack.config.dev.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,7 +124,13 @@ module.exports = {
// First, run the linter.
// It's important to do this before Babel processes the JS.
{
test: /\.(js|jsx|mjs)$/,
test: function testForJsFilesExcludingBsFiles(fileName) {
// Do not lint `*.bs.js` files, generated by BuckleScript.
if (fileName.endsWith('.bs.js')) {
return false;
}
return /\.(js|jsx|mjs)$/.test(fileName);
},
enforce: 'pre',
use: [
{
Expand Down
8 changes: 7 additions & 1 deletion packages/react-scripts/config/webpack.config.prod.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,7 +130,13 @@ module.exports = {
// First, run the linter.
// It's important to do this before Babel processes the JS.
{
test: /\.(js|jsx|mjs)$/,
test: function testForJsFilesExcludingBsFiles(fileName) {
// Do not lint `*.bs.js` files, generated by BuckleScript.
if (fileName.endsWith('.bs.js')) {
return false;
}
return /\.(js|jsx|mjs)$/.test(fileName);
},
enforce: 'pre',
use: [
{
Expand Down