-
-
Notifications
You must be signed in to change notification settings - Fork 27k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update documentation, add file compression #3632
Conversation
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed. If you have received this in error or have any questions, please contact us at [email protected]. Thanks! |
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this PR! What's the story for Windows compatibility? Is there an npm package we can use instead?
Typically web server takes care of this. Do we really need it? |
Probably not. |
I'd say let's leave it to web servers. |
While web servers do this, I would like to say that I currently am working on a simple dashboard for a client, and the client demanded the code to be serve statically (via S3 bucket). After I've tried my best to convince the client to at least set up a simple server, the client agreed and is using serve This simply "server" apparently doesn't know how to Since |
As proposed in #1908 and #3169 gzip file can be just a postbuild script in the package.json, here is a simple example in the README.md file