-
-
Notifications
You must be signed in to change notification settings - Fork 27k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ejecting should ensure you have clean git status #2090
Closed
Closed
Changes from 5 commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
61cfcec
when build is failing due to ESLint errors, filter warnings out
milocosmopolitan bdabc3e
Ejecting should ensure you have clean git status
milocosmopolitan 6ff17ae
Ejecting should ensure you have clean git status
milocosmopolitan eca2714
comment indication
milocosmopolitan 8be4f32
fixed es6 const {} issue for version less than node 7
milocosmopolitan 0d68efe
fix no-inner-declarations of function
milocosmopolitan fe3bb7f
remove checking .git directory
milocosmopolitan cf57f57
Give the output in an easy-to-parse format for scripts
milocosmopolitan 44ae1e2
Merge branch 'master' of https://github.com/milocosmopolitan/create-r…
milocosmopolitan c3dc075
Merge branch 'master' into eject
milocosmopolitan e7e0392
improved error message
milocosmopolitan a72073c
count dirty files only
milocosmopolitan 70b9b5b
Merge branch 'master' of https://github.com/facebookincubator/create-…
milocosmopolitan e317052
solve merge conflict
milocosmopolitan ad7cd2c
Update build.js
milocosmopolitan File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You might want to use https://github.com/sindresorhus/find-up
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @thejameskyle, can you explain what are the benefits of using that library? Is it because it returns promised result? Cause I was trying to avoid using third-party library as possible. If promise is necessary I could just use instantiate Promise.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@milocosmopolitan someone might have their git directory several levels up the tree, especially if it's a monorepo.
However, you shouldn't be checking for the existence of
.git
at all -- simply execute a git command in the directory and see if it errors out 😄.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See 1288's files for inspiration.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Timer, I've made a change according to your suggestion.