Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support for Node 14 #11747

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Drop support for Node 14 #11747

wants to merge 2 commits into from

Conversation

iansu
Copy link
Contributor

@iansu iansu commented Dec 13, 2021

Node 16 is LTS now so that should be our minimum supported version.

@mwanagosos
Copy link

mwanagosos commented Dec 14, 2021

I've noticed that react-dev-utils will require Node 16 too. Will it apply only to versions 12.x?
Currently, the package.json in react-scripts mentions "react-dev-utils": "^11.0.4". Shouldn't it be a 12.x version instead?
The webpack.config.js uses ForkTsCheckerWarningWebpackPlugin that isn't included in "react-dev-utils": "^11.0.4".

@iansu I've opened a separate ticket for that a bit less than 2 months ago
#11567

@@ -40,12 +40,12 @@ const currentNodeVersion = process.versions.node;
const semver = currentNodeVersion.split('.');
const major = semver[0];

if (major < 14) {
if (major < 6) {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
if (major < 6) {
if (major < 16) {

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants