Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change create-router-dom example link in docs to v6 of the library #11857

Open
idrm opened this issue Dec 30, 2021 · 1 comment
Open

Change create-router-dom example link in docs to v6 of the library #11857

idrm opened this issue Dec 30, 2021 · 1 comment
Labels
issue: bug report needs triage

Comments

@idrm
Copy link

idrm commented Dec 30, 2021

The CRA documentation on using react-router-dom links to an example that showcases the previous version of the library (v5), which is incompatible with the (regular) npm/yarn install of v6. I suggest changing the link to https://github.com/remix-run/react-router/blob/main/docs/getting-started/tutorial.md.
@tom-raley
Copy link

@idrm I'd be happy to take this, ran into issues with it yesterday.

@snyk-bot snyk-bot mentioned this issue Sep 29, 2020
Closed
xdiegors added a commit to xdiegors/create-react-app that referenced this issue Dec 8, 2022
@xdiegors
Update adding-a-router.md
e81ebe1 
Solve issue facebook#11857
xdiegors added a commit to xdiegors/create-react-app that referenced this issue Dec 8, 2022
@xdiegors
Update adding-a-router.md
aa86567 
Solve issue facebook#11857
@xdiegors xdiegors mentioned this issue Dec 8, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
issue: bug report needs triage
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@idrm @tom-raley