Make C++ tools configurable #847
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The move to `cxx_internal_tools` broke open source users that had a custom `make_comp_db` to work around facebook#307. This commit makes it configurable so that OSS users can again provide their own script to generate legal `compile_commands.json` files. A few remaining tools are made `PUBLIC` so that OSS users can simply reuse them.
facebook-github-bot
added
the
CLA Signed
|
@facebook-github-bot has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. (Because this pull request was imported automatically, there will not be any future comments.) |
facebook-github-bot
pushed a commit
to facebook/buck2-prelude
that referenced
this pull request
Jan 22, 2025
Summary: The move to `cxx_internal_tools` broke open source users that had a custom `make_comp_db` to work around facebook/buck2#307. This commit makes it configurable so that OSS users can again provide their own script to generate legal `compile_commands.json` files. A few remaining tools are made `PUBLIC` so that OSS users can simply reuse them. X-link: facebook/buck2#847 Reviewed By: dtolnay Differential Revision: D68327054 fbshipit-source-id: 3c553e7d575928e07728e7525138f45d9b6f2413
|
This pull request has been merged in 1dc2855. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The move to
cxx_internal_toolsbroke open source users that had a custommake_comp_dbto work around #307.This commit makes it configurable so that OSS users can again provide their own script to generate legal
compile_commands.jsonfiles.A few remaining tools are made
PUBLICso that OSS users can simply reuse them.