github: disallow libc 0.2.165 #814
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: `sysinfo` is fixed by GuillaumeGomez/sysinfo#1393 which is released as v0.32.1. But there are breaking changes compare to current sysinfo v0.30.11 we have internally and it needs to be migrated. Differential Revision: D66499693
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D66499693 |
facebook-github-bot
pushed a commit
to facebook/buck2-shims-meta
that referenced
this pull request
Nov 26, 2024
Summary: X-link: facebook/buck2#814 `libc` 0.2.165 was released recently and it breaks `sysinfo` crate for Mac. `sysinfo` is fixed by GuillaumeGomez/sysinfo#1393 which is released as v0.32.1. But there are breaking changes compare to current sysinfo v0.30.11 we have internally and it needs to be migrated. Reviewed By: ndmitchell, Will-MingLun-Li Differential Revision: D66499693 fbshipit-source-id: 390c76f85ce431f39882345500593ae008664b80
|
This pull request has been merged in 2374a1e. |
|
Fyi 0.2.165 was yanked, 0.2.166 was released with a fix |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
sysinfois fixed by GuillaumeGomez/sysinfo#1393 which is released as v0.32.1.But there are breaking changes compare to current sysinfo v0.30.11 we have internally and it needs to be migrated.
Differential Revision: D66499693