buck2 | Filter out frameworks from apple_static_archive

Summary:
There are a few-and-far-between targets that deliberately inject `-framework Foundation`, etc. into linker_args.

Because they take the form of an `-option` arg followed by another arg, the framework names make their way into the list of files used by `apple_static_archive()`

This diff filters these out as non-files in the  prexisting `_filter_files()` function.

Differential Revision: D68766678

fbshipit-source-id: 17b4bd52c8b023400ef4965cc7d8bb11c7ac0bb5

prelude/apple/tools/static_archive_linker.py

@@ -11,13 +11,25 @@
 
 
 def _filter_files(args):
-    # Filter out any arg that starts with '-'. Assumes that other args are
-    # files that should be passed to libtool.
+    # Filter out any arg that starts with '-'.  Also filter out passed arg
+    # pairs like '-framework Cocoa'. Assumes that other args are files that
+    # should be passed to libtool.
     # Rationale: There's no way of checking if an arg is intended to be a file.
-    # Having a filter that looks checks if a file with a given path exists will
+    # Having a filter that checks if a file with a given path exists will
     # silently remove the arg in the event of an error where arg is a file and
     # the file does not exist.
-    return [arg for arg in args if not arg.startswith("-")]
+    filtered_args = []
+    skip_next = False
+    for arg in args:
+        if skip_next:
+            skip_next = False
+            continue
+        if arg.startswith("-"):
+            if arg == "-framework":
+                skip_next = True
+            continue
+        filtered_args.append(arg)
+    return filtered_args
 
 
 def _main() -> None: