Skip to content

Commit

Permalink
rust-project: Don't log to scuba in CI
Browse files Browse the repository at this point in the history
Summary: The vast majority of rust-project telemetry is coming from CI. We don't need that.

Reviewed By: Wilfred

Differential Revision: D68861251

fbshipit-source-id: 0de1f60eee8d5ed4d0da44345f19facfe47b8579
  • Loading branch information
darichey authored and facebook-github-bot committed Jan 30, 2025
1 parent 25d9ecc commit 683a7d5
Showing 1 changed file with 37 additions and 24 deletions.
61 changes: 37 additions & 24 deletions integrations/rust-project/src/scuba.rs
Original file line number Diff line number Diff line change
Expand Up @@ -14,27 +14,31 @@ use crate::cli::Input;

#[cfg(fbcode_build)]
pub(crate) fn log_develop(duration: Duration, input: Input, invoked_by_ra: bool) {
let mut sample = new_sample("develop");
sample.add("duration_ms", duration.as_millis() as i64);
sample.add("input", format!("{:?}", input));
sample.add("revision", get_sl_revision());
sample.add("invoked_by_ra", invoked_by_ra);
sample.log();
sample.flush(Duration::from_millis(500));
if !is_ci() {
let mut sample = new_sample("develop");
sample.add("duration_ms", duration.as_millis() as i64);
sample.add("input", format!("{:?}", input));
sample.add("revision", get_sl_revision());
sample.add("invoked_by_ra", invoked_by_ra);
sample.log();
sample.flush(Duration::from_millis(500));
}
}

#[cfg(not(fbcode_build))]
pub(crate) fn log_develop(_duration: Duration, _input: Input, _invoked_by_ra: bool) {}

#[cfg(fbcode_build)]
pub(crate) fn log_develop_error(error: &anyhow::Error, input: Input, invoked_by_ra: bool) {
let mut sample = new_sample("develop");
sample.add("error", format!("{:#?}", error));
sample.add("input", format!("{:?}", input));
sample.add("revision", get_sl_revision());
sample.add("invoked_by_ra", invoked_by_ra);
sample.log();
sample.flush(Duration::from_millis(500));
if !is_ci() {
let mut sample = new_sample("develop");
sample.add("error", format!("{:#?}", error));
sample.add("input", format!("{:?}", input));
sample.add("revision", get_sl_revision());
sample.add("invoked_by_ra", invoked_by_ra);
sample.log();
sample.flush(Duration::from_millis(500));
}
}

#[cfg(not(fbcode_build))]
Expand All @@ -52,23 +56,27 @@ fn get_sl_revision() -> String {

#[cfg(fbcode_build)]
pub(crate) fn log_check(duration: Duration, saved_file: &Path, use_clippy: bool) {
let mut sample = new_sample("check");
sample.add("duration_ms", duration.as_millis() as i64);
sample.add("saved_file", saved_file.display().to_string());
sample.add("use_clippy", use_clippy.to_string());
sample.log();
if !is_ci() {
let mut sample = new_sample("check");
sample.add("duration_ms", duration.as_millis() as i64);
sample.add("saved_file", saved_file.display().to_string());
sample.add("use_clippy", use_clippy.to_string());
sample.log();
}
}

#[cfg(not(fbcode_build))]
pub(crate) fn log_check(_duration: Duration, _saved_file: &Path, _use_clippy: bool) {}

#[cfg(fbcode_build)]
pub(crate) fn log_check_error(error: &anyhow::Error, saved_file: &Path, use_clippy: bool) {
let mut sample = new_sample("check");
sample.add("error", format!("{:#?}", error));
sample.add("saved_file", saved_file.display().to_string());
sample.add("use_clippy", use_clippy.to_string());
sample.log();
if !is_ci() {
let mut sample = new_sample("check");
sample.add("error", format!("{:#?}", error));
sample.add("saved_file", saved_file.display().to_string());
sample.add("use_clippy", use_clippy.to_string());
sample.log();
}
}

#[cfg(not(fbcode_build))]
Expand All @@ -95,3 +103,8 @@ fn new_sample(kind: &str) -> scuba::ScubaSampleBuilder {
}
sample
}

#[cfg(fbcode_build)]
fn is_ci() -> bool {
std::env::var("SANDCASTLE").is_ok()
}

0 comments on commit 683a7d5

Please sign in to comment.