Allow 'static in native functions

Reviewed By: JakobDegen

Differential Revision: D59382674

fbshipit-source-id: e2647e9d974554ba7ee01076cbdbfd8d2db1f600

starlark-rust/starlark/src/tests/derive/module/basic.rs

@@ -25,6 +25,7 @@ use crate::values::list_or_tuple::UnpackListOrTuple;
 use crate::values::Heap;
 use crate::values::StringValue;
 use crate::values::Value;
+use crate::values::ValueOfUnchecked;
 
 // The examples from the starlark_module documentation.
 #[test]
@@ -61,3 +62,15 @@ fn test_starlark_methods() {
 
     MethodsBuilder::new().with(methods).build();
 }
+
+#[test]
+fn test_static_allowed() {
+    #[starlark_module]
+    fn globals(globals: &mut GlobalsBuilder) {
+        fn test<'v>() -> anyhow::Result<ValueOfUnchecked<'v, &'static str>> {
+            panic!()
+        }
+    }
+
+    GlobalsBuilder::standard().with(globals).build();
+}

starlark-rust/starlark_derive/src/module/parse/fun.rs

@@ -460,7 +460,7 @@ fn check_lifetimes_in_type(ty: &Type, has_v: bool) -> syn::Result<()> {
         #[allow(clippy::collapsible_if)]
         fn visit_lifetime(&mut self, lifetime: &'ast Lifetime) {
             if self.result.is_ok() {
-                if lifetime.ident != "_" {
+                if lifetime.ident != "_" && lifetime.ident != "static" {
                     if lifetime.ident != "v" {
                         self.result = Err(syn::Error::new(
                             lifetime.span(),