Skip to content

Commit

Permalink
Disable link order fixup until the perf fix is ready
Browse files Browse the repository at this point in the history
Summary:
The change in D67197102 makes the link order in link groups consistent with the _regular_ link order. However, the implementation has a perf and memory impact that affects e.g. Glean indexing.

The perf fix is underway but until it's ready we should temporarily disable the link order fixup.

#buildall

Reviewed By: patskovn, iamirzhan

Differential Revision: D68074196

fbshipit-source-id: e04cbde765db3e5c7342dc430c2e67e875e1be98
  • Loading branch information
artempyanykh authored and facebook-github-bot committed Jan 13, 2025
1 parent b6c8893 commit a8851c1
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion cxx/link_groups.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -446,7 +446,7 @@ def get_filtered_labels_to_links_map(
link_group_preferred_linkage,
pic_behavior,
roots,
fixup_link_order = link_strategy == LinkStrategy("shared"),
fixup_link_order = False, # TODO(arr): re-enable when the perf fix D67982726 is ready
)

# An index of target to link group names, for all link group library nodes.
Expand Down

0 comments on commit a8851c1

Please sign in to comment.