Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docusaurus] Fix broken links #3300

Closed
wants to merge 2 commits into from
Closed

Conversation

CristianLara
Copy link
Contributor

Context

Duplicate of same change in botorch: pytorch/botorch#2720

Motivation

The recent website upgrade moved the location of tutorials and api reference breaking existing links to those. Here we fix those links and also configure Docusaurus to raise an error on broken links in the future.

Test Plan

Docusaurus checks for broken links when creating a production build. Running ./scripts/make_docs.sh -b now results in a clean build with no broken links reported.

Related PRs

tutorials were moved to the /docs/tutorials directory, api reference was moved to an external site
Would have prevented us from publishing the site with broken links.

For broken anchors we just warn since those still take us to the correct page.
@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Feb 3, 2025
@CristianLara CristianLara requested a review from Balandat February 3, 2025 07:40
@facebook-github-bot
Copy link
Contributor

@CristianLara has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.04%. Comparing base (6ae638c) to head (5e19857).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3300   +/-   ##
=======================================
  Coverage   96.04%   96.04%           
=======================================
  Files         518      518           
  Lines       52162    52162           
=======================================
  Hits        50098    50098           
  Misses       2064     2064           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@facebook-github-bot
Copy link
Contributor

@CristianLara merged this pull request in ac55041.

@saitcakmak saitcakmak deleted the docusaurus-fix-broken-links branch February 3, 2025 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Do not delete this pull request or issue due to inactivity. Merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants