Remove get_best_parameters_from_model_predictions #3295
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: This helper wraps `get_best_parameters_from_model_predictions_with_trial_index` and throws away the trial index. We have too many best point helpers that make this part of the codebase into a maintenance nightmare. Removing this & replacing is only use case with `get_best_parameters_from_model_predictions_with_trial_index` before making BC-breaking changes to the function signature. Reviewed By: esantorella Differential Revision: D68908977
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D68908977 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3295 +/- ##
==========================================
- Coverage 96.04% 96.04% -0.01%
==========================================
Files 518 518
Lines 52162 52157 -5
==========================================
- Hits 50098 50093 -5
Misses 2064 2064 ☔ View full report in Codecov by Sentry. |
|
This pull request has been merged in cd7739c. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: This helper wraps
get_best_parameters_from_model_predictions_with_trial_indexand throws away the trial index. We have too many best point helpers that make this part of the codebase into a maintenance nightmare. Removing this & replacing is only use case withget_best_parameters_from_model_predictions_with_trial_indexbefore making BC-breaking changes to the function signature.Reviewed By: esantorella
Differential Revision: D68908977