Replace usage of exp_to_df with Experiment.to_df #3279
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D68774600 |
saitcakmak
added a commit
to saitcakmak/Ax
that referenced
this pull request
Jan 28, 2025
Summary: Updates some use cases of `exp_to_df` to utilize `Experiment.to_df`. This diff handles most usage that doesn't rely on the kwargs exposed on `exp_to_df`. The remaining usage will be updated after adding the necessary options to `Experiment.to_df`. Differential Revision: D68774600
saitcakmak
force-pushed
the
export-D68774600
branch
from
4b13714 to
d66aaeb
Compare
|
This pull request was exported from Phabricator. Differential Revision: D68774600 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3279 +/- ##
==========================================
- Coverage 96.01% 96.00% -0.01%
==========================================
Files 514 514
Lines 51955 51953 -2
==========================================
- Hits 49884 49880 -4
- Misses 2071 2073 +2 ☔ View full report in Codecov by Sentry. |
saitcakmak
added a commit
to saitcakmak/Ax
that referenced
this pull request
Jan 28, 2025
Summary: Updates some use cases of `exp_to_df` to utilize `Experiment.to_df`. This diff handles most usage that doesn't rely on the kwargs exposed on `exp_to_df`. The remaining usage will be updated after adding the necessary options to `Experiment.to_df`. Reviewed By: bernardbeckerman Differential Revision: D68774600
saitcakmak
force-pushed
the
export-D68774600
branch
from
d66aaeb to
ae645a6
Compare
|
This pull request was exported from Phabricator. Differential Revision: D68774600 |
saitcakmak
added a commit
to saitcakmak/Ax
that referenced
this pull request
Jan 28, 2025
Summary: Updates some use cases of `exp_to_df` to utilize `Experiment.to_df`. This diff handles most usage that doesn't rely on the kwargs exposed on `exp_to_df`. The remaining usage will be updated after adding the necessary options to `Experiment.to_df`. Reviewed By: bernardbeckerman Differential Revision: D68774600
saitcakmak
force-pushed
the
export-D68774600
branch
from
ae645a6 to
5b38faf
Compare
|
This pull request was exported from Phabricator. Differential Revision: D68774600 |
Summary: Updates some use cases of `exp_to_df` to utilize `Experiment.to_df`. This diff handles most usage that doesn't rely on the kwargs exposed on `exp_to_df`. The remaining usage will be updated after adding the necessary options to `Experiment.to_df`. Reviewed By: bernardbeckerman Differential Revision: D68774600
saitcakmak
force-pushed
the
export-D68774600
branch
from
5b38faf to
789e73d
Compare
|
This pull request was exported from Phabricator. Differential Revision: D68774600 |
|
This pull request has been merged in de82bcc. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Updates some use cases of
exp_to_dfto utilizeExperiment.to_df. This diff handles most usage that doesn't rely on the kwargs exposed onexp_to_df. The remaining usage will be updated after adding the necessary options toExperiment.to_df.Differential Revision: D68774600