Deprecate GenerationStrategy.trials_as_df #3275
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D68629386 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3275 +/- ##
==========================================
- Coverage 96.01% 96.01% -0.01%
==========================================
Files 512 512
Lines 51725 51711 -14
==========================================
- Hits 49663 49649 -14
Misses 2062 2062 ☔ View full report in Codecov by Sentry. |
Summary: Introduces `Experiment.to_df`, which will replace `exp_to_df` and `GS.trials_as_df` to present a unified API for summarizing an experiment. The summary will still be available as an analysis card via the `Summary` analysis class. How does this differ from existing `exp_to_df` and `GS.trials_as_df`: - `GS.trials_as_df` is rather barebones, and primarily lists the arms, trial status and the node/model that generated the arm. It does not appear to have much usage, so we'll deprecate it. - The default behavior of `exp_to_df` differs in a few fields. It does not list the node name or metadata, and has an `is_feasible` field (missing here) that is computed in a somewhat strange way (for a boolean field). It also exposes a number of kwargs that can modify its behavior. These seem to be utilized in some plotting related utilities. The plan is to deprecate it in favor of `Experiment.to_df` after figuring out whether the additional options are necessary. If we want to expose an `is_feasible` field, we should come up with a better definition for the field that we utilize consistently across the codebase, such as in best point utilities. Reviewed By: mgarrard, lena-kashtelyan Differential Revision: D68720999
Summary: Deprecates `GS.trials_as_df` in favor of the more informative `Experiment.to_df`. Reviewed By: lena-kashtelyan Differential Revision: D68629386
saitcakmak
force-pushed
the
export-D68629386
branch
from
513c304 to
dc1f6bf
Compare
|
This pull request was exported from Phabricator. Differential Revision: D68629386 |
|
This pull request has been merged in 4bead35. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Deprecates
GS.trials_as_dfin favor of the more informativeExperiment.to_df.Differential Revision: D68629386