Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade for Fabulous.XamarinForms to 4.2 #559

Merged
merged 3 commits into from
Sep 16, 2019
Merged

Upgrade for Fabulous.XamarinForms to 4.2 #559

merged 3 commits into from
Sep 16, 2019

Conversation

SergejDK
Copy link
Collaborator

This PR
fix #556
and fix #459 (need to test but should be working now)

Currently getting an error on "GroupableItemsViewViewer" because it is not defined.

@SergejDK SergejDK changed the title Upgrade for Fabulous.XamarinForms Upgrade for Fabulous.XamarinForms to 4.2 Sep 11, 2019
@SergejDK
Copy link
Collaborator Author

SergejDK commented Sep 13, 2019 •
edited
Loading

@TimLariviere
upgrade is done. Tested it on OSX and Windows.

The fix for the GTK issue with the Navigationpage is gone, too. I found a new issue but I don't know if this is caused by us or XF itself:

Bildschirmfoto 2019-09-13 um 21 49 23

The ' seems to be a encoding issue of XF. I know that there was a bug with this.
Do you know something about this?

@SergejDK SergejDK marked this pull request as ready for review September 13, 2019 19:56
@SergejDK
Copy link
Collaborator Author

@TimLariviere
the mentioned issue is caused by xamarin.forms. So we can ignore it for the time being.

TimLariviere
TimLariviere requested changes Sep 16, 2019
View reviewed changes
Copy link
Member

@TimLariviere TimLariviere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job! I only added one comment 😄

Fabulous.XamarinForms/src/Fabulous.XamarinForms/Xamarin.Forms.Core.json Outdated
"defaultValue": "null"
},
{
"name": "FooterTemplate",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you declare only the direct property and not the Template one (here Footer vs FooterTemplate, and the others as well) please ?

We don't provide direct support for Template properties (DataTemplate, etc.).

Instead we only expose one property that accepts a ViewElement that we put directly in the "real" property (e.g. Footer) since we don't need to use BindingContext.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So I only have to delete those parts, correct?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes

@SergejDK SergejDK merged commit caa7586 into fabulous-dev:master Sep 16, 2019
@SergejDK SergejDK deleted the xfupgrade42 branch September 16, 2019 13:29
@TimLariviere TimLariviere mentioned this pull request Sep 19, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TimLariviere TimLariviere TimLariviere approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Upgrade Xamrin.Forms to 4.2.0.709249 [Samples][GTK] Allcontrols/TicTacToe
2 participants
@SergejDK @TimLariviere