Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Workaround #343 #347

Merged
merged 1 commit into from
Feb 28, 2019
Merged

Workaround #343 #347

merged 1 commit into from
Feb 28, 2019

Conversation

kerams
Copy link
Contributor

@kerams kerams commented Feb 26, 2019 •
edited
Loading

Workaround #343

TimLariviere
TimLariviere approved these changes Feb 27, 2019
View reviewed changes
Copy link
Member

@TimLariviere TimLariviere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@TimLariviere
Copy link
Member

Just thinking about it.
Does it work on your device when deploying as a Release APK?

I fear that the Linker will remove this unused variable.

@kerams
Copy link
Contributor Author

kerams commented Feb 27, 2019 •
edited
Loading

Good point, I'll try it with linking enabled. I was suprised the F# optimizer itself hadn't removed it.

@kerams
Copy link
Contributor Author

kerams commented Feb 27, 2019

Can confirm that this workaround works with Sdk and user assembly linking (skipping FSharp.Core, otherwise I get a crash instantly).

@TimLariviere TimLariviere merged commit dcc396f into fabulous-dev:master Feb 28, 2019
@kerams kerams deleted the patch-1 branch February 28, 2019 11:08
@TimLariviere TimLariviere mentioned this pull request Mar 5, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TimLariviere TimLariviere TimLariviere approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kerams @TimLariviere