Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update portacode #338

Merged
merged 7 commits into from
Feb 20, 2019
Merged

update portacode #338

merged 7 commits into from
Feb 20, 2019

Conversation

dsyme
Copy link
Collaborator

@dsyme dsyme commented Feb 19, 2019

This updates portacode.

  • Some additional bugs with top-level mutable values have been fixed in the interpreter

  • The command line to start the tool is now

    fabulous --watch --send
    

    which defaults to the localhost webhook URL.

Arguments:
   --watch           Watch the source files of the project for changes
   --webhook:<url>   Send the JSON-encoded contents of the PortaCode to the webhook
   --send            Equivalent to --webhook:http://localhost:9867/update

Copy link
Member

@TimLariviere TimLariviere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good. Seems to cover #306 as well. :)

Could you just revert the version number (Directory.Build.props and template.json) please?
I prefer to bump it only in the release PR.

Also I think LiveUpdate output need to be updated
https://github.com/fsprojects/Fabulous/blob/3474315534b0edee60f195df6f4f13f89e897a26/src/Fabulous.LiveUpdate/LiveUpdate.fs#L67-L82

@dsyme dsyme merged commit d65687c into fabulous-dev:master Feb 20, 2019
@TimLariviere TimLariviere mentioned this pull request Mar 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants