New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(V6): brush layering POC #7880

Closed

ShaMan123 wants to merge 86 commits into master from v6-brush-layering

Contributor

ShaMan123 commented Apr 17, 2022 •

edited

Loading

Fabric.React.App.Sandbox.-.Google.Chrome.2022-04-17.18-41-52.mp4

This is a nice POC that shows how to use Layer in an advanced way as described in #7860 (comment)
Notice that the brush is drawn below the red static rect as well as below the overlayColor. It's because the Layer is placed there.

View the diff

ShaMan123 added 30 commits

April 3, 2022 23:32


          apply 7744 patch (no binaries)

1a191a7


          apply 7744 patch (binaries)

26e8392


          commit #7744 review

7d793b3

#7744 (review)


          patch2


          Update spray_brush.class.js

02a8ffa


          enable text editing under group

0d3690f


          migrate back to isDescendantOf

ff0346a


          render bg

812f02a


          fix(): clear canvas from entire object tree

053946c

in case object is a collection


          fix(): center object in case object is nested

db76c44


          Update eraser_brush.mixin.js

04aad5b


          Update canvas.class.js

8c1c535


          Update canvas_events.mixin.js

3fd4af2


          lint

58e9be2


          safeguard from adding group to itself

c2ef2f5


          Update object_ancestry.mixin.js

f0145b5


          patch tests from v6!

cb20b81


          Update canvas_grouping.mixin.js

347f80d


          Update canvas.class.js

a56d55e


          create layer

22045b6


          Update layer.class.js

724792a


          warn

7163ad3


          Update group_layout.js

2a426e7


          Update group_layout.js

5e3fc1f


          remove redundant logic

2b1f680


          Update canvas_grouping.mixin.js

1ad5cc8


          fix(): calling sendPointToPlane

11c828f


          Update group.class.js

b6fa3dc


          refactor enterGroup

e9afc89


          invalidate groups after active selection change

d8f8251

ShaMan123 added 4 commits

May 1, 2022 09:44


          fix(): pass options to _getTransformedDimensions

4c0c142


          Revert "fix(): pass options to _getTransformedDimensions"

23416d1

This reverts commit 4c0c142.


          fix(): getDimensions no strokeWidth

2f27480

`_getNonTransformedDimensions`
`_getTransformedDimensions`


          fix(): _getTransformedDimensions

2a26286

account for size only

stale bot commented May 1, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale bot added the stale label


          Merge branch 'v6-layer' into v6-brush-layering

59e2532

stale bot removed the stale label


          Merge branch 'master' into v6-brush-layering

c2fcd8c

stale bot commented Jun 12, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale bot added the stale label

ShaMan123 removed the stale label


          Merge branch 'master' into v6-brush-layering

0c7162c

stale bot commented Jun 28, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale bot added the stale label

ShaMan123 removed the stale label

ShaMan123 mentioned this pull request

Shadow causes drop in perf #8076

Open

stale bot commented Jul 30, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale bot added the stale label

ShaMan123 removed the stale label

stale bot commented Sep 21, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale bot added the stale label

ShaMan123 removed the stale label

asturur added feature awaiting evaluation and removed experimental labels

ShaMan123 closed this

Contributor Author

ShaMan123 commented May 6, 2024

layers didn't pass the doorstep

ShaMan123 deleted the v6-brush-layering branch

May 6, 2024 16:29

ShaMan123 mentioned this pull request

feat(Brush API): Observable, clipPath #8476

Closed

2 tasks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting evaluation feature