Fixed CountRule and ClassPerFileRule #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ClassPerFileRule should mark all classes after the first one as violations, but it ignored every other class. It was because counter was reset after adding a violation. It worked like this: TMyClass1 <- counter increases to 1 TMyClass2 <- violation is added, counter resets to 0 TMyClass3 <- counter increases to 1 TMyClass4 <- violation is added, counter resets to 0 etc. After setting "reset = false;" number of violations suddenly increased to huge numbers. For a simple test with 5 classes, 21 violation was registered instead of 4. It was because of a bug in CountRule. After the limit was exceeced, a violation was added to every node, not just to those that match the search criteria. So I turned shouldCheck into a guard clause that returns immediately if the node does not match. Also I removed "Object dataRef" instance variable from CountRule, because it seems unused.
|
Good catch. Thank you. |
fabriciocolombo
added a commit
that referenced
this pull request
Dec 17, 2015
Fixed CountRule and ClassPerFileRule
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ClassPerFileRuleshould mark all classes after the first one as violations, but it ignored every other class. It was because the counter was reset after adding a violation.It worked like this:
After setting
reset = false;number of violations suddenly increased to huge numbers. For a simple test with 5 classes, 21 violation was registered instead of 4. It was because of a bug inCountRule. After the limit was exceeced, a violation was added to every node, not just to those that match the search criteria. So I turnedshouldCheckinto a guard clause that returns immediately if the node does not match.Also I removed
Object dataRefinstance variable fromCountRule, because it seems unused.