Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #4931: using coarse locking to prevent odd concurrent behavior #4945

Merged
merged 5 commits into from
Mar 9, 2023

Conversation

shawkins
Copy link
Contributor

@shawkins shawkins commented Mar 2, 2023

Description

Switches all of the operation methods to be synchronized to ensure full consistency - beyond the map of resources we also hold some mutable crd state in CustomResourceDefinitionProcessor, which this will cover as well. This could also easily be implemented in CrudDispatcher, but that requires another release of the mock webserver.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change
  • Chore (non-breaking change which doesn't affect codebase;
    test, version modification, documentation, etc.)

Checklist

  • Code contributed by me aligns with current project license: Apache 2.0
  • I Added CHANGELOG entry regarding this change
  • I have implemented unit tests to cover my changes
  • I have added/updated the javadocs and other documentation accordingly
  • No new bugs, code smells, etc. in SonarCloud report
  • I tested my code in Kubernetes
  • I tested my code in OpenShift

@shawkins shawkins changed the title fix #4931: using course locking to prevent odd concurrent behavior fix #4931: using coarse locking to prevent odd concurrent behavior Mar 3, 2023
@shawkins shawkins force-pushed the iss4931 branch 2 times, most recently from 8bbb7f0 to 1032d2b Compare March 6, 2023 16:07
@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 6, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

74.6% 74.6% Coverage
0.0% 0.0% Duplication

@manusa manusa added this to the 6.5.0 milestone Mar 9, 2023
@manusa manusa merged commit 73b2a04 into fabric8io:master Mar 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants