Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix home dir win #4198

Merged
merged 3 commits into from
Dec 22, 2022
Merged

Fix home dir win #4198

merged 3 commits into from
Dec 22, 2022

Conversation

sunix
Copy link
Collaborator

@sunix sunix commented Jun 9, 2022 •
edited
Loading

Description

This should fix problem occured in eclipse-jkube/jkube#1540
Resolving the folder where .kube/config shoud be located, it should behave like oc and kubectl: On Windows, looking at the the HOME env variable at first.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change
  • Chore (non-breaking change which doesn't affect codebase;
    test, version modification, documentation, etc.)

Checklist

  • Code contributed by me aligns with current project license: Apache 2.0
  • I Added CHANGELOG entry regarding this change
  • I have implemented unit tests to cover my changes
  • I have added/updated the javadocs and other documentation accordingly
  • No new bugs, code smells, etc. in SonarCloud report
  • I tested my code in Kubernetes
  • I tested my code in OpenShift

@sunix sunix force-pushed the fixHomeDirWin branch 6 times, most recently from 729e3a9 to f9fe1b6 Compare June 10, 2022 07:10
@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

53.8% 53.8% Coverage
0.0% 0.0% Duplication

@sunix sunix marked this pull request as ready for review June 10, 2022 12:17
@rohanKanojia rohanKanojia requested review from manusa and shawkins July 12, 2022 09:14
@rohanKanojia
Copy link
Member

@sunix : Could you please resolve this minor conflict?

shawkins
shawkins approved these changes Jul 12, 2022
View reviewed changes
Copy link
Contributor

@shawkins shawkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sunix
Copy link
Collaborator Author

sunix commented Jul 12, 2022 •
edited
Loading

@sunix : Could you please resolve this minor conflict?

Yes done, I have rebased

@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

69.2% 69.2% Coverage
0.0% 0.0% Duplication

@sunix
Copy link
Collaborator Author

sunix commented Nov 23, 2022

TODO : try not to add additional dependencies

@sunix sunix force-pushed the fixHomeDirWin branch 3 times, most recently from 6bb8bc9 to 9d5c905 Compare December 20, 2022 15:56
@sunix sunix force-pushed the fixHomeDirWin branch 3 times, most recently from 8614c00 to 4efd4ca Compare December 22, 2022 09:10
@sunix
chore(test remove ext dep): reverting adding the junit pioneer extern…
2bfac50 
…al dependency in unit tests

Signed-off-by: Sun Seng David TAN <[email protected]>
@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

73.3% 73.3% Coverage
0.0% 0.0% Duplication

@manusa manusa added this to the 6.4.0 milestone Dec 22, 2022
@manusa manusa merged commit f8bf577 into fabric8io:master Dec 22, 2022
@sunix sunix mentioned this pull request Jan 3, 2023
Closed
@manusa manusa mentioned this pull request Jan 23, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manusa manusa manusa approved these changes

@shawkins shawkins shawkins approved these changes

@oscerd oscerd oscerd approved these changes

@andreaTP andreaTP andreaTP approved these changes

@rohanKanojia rohanKanojia rohanKanojia approved these changes

Assignees

@sunix sunix

Labels
None yet
Projects
None yet
Milestone
6.4.0
Development

Successfully merging this pull request may close these issues.
6 participants
@sunix @rohanKanojia @manusa @shawkins @oscerd @andreaTP