Fix #3240: MicroTime serialises incorrectly; Add custom serializer/deserializer for MicroTime class

[rohanKanojia]

Description

Fix #3240

Add Custom MicroTime with custom Serializer/Deserializers in order to
convert to a timestamp string

Signed-off-by: Rohan Kumar [email protected]

Type of change

• Bug fix (non-breaking change which fixes an issue)
• Feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change
• Chore (non-breaking change which doesn't affect codebase;
  test, version modification, documentation, etc.)

Checklist

• Code contributed by me aligns with current project license: Apache 2.0
• I Added CHANGELOG entry regarding this change
• I have implemented unit tests to cover my changes
• I have added/updated the javadocs and other documentation accordingly
• No new bugs, code smells, etc. in SonarCloud report
• I tested my code in Kubernetes
• I tested my code in OpenShift

[manusa]

As we discussed after today's stand-up, it would be much better if these fields that represent time were typed as OffsetDateTime , or any other type that properly represents timestamps with timezone information.

However, for consistency reasons and since the rest of fields we already have are parsed to timestamp strings, we can leave this for now.

For v6.0.0 it might be a good idea to convert all of those fields into a proper type.

These are some examples (there are many more) of timestamp fields that are currently typed as strings:

• kubernetes-client/kubernetes-model-generator/kubernetes-model-core/src/generated/java/io/fabric8/kubernetes/api/model/ObjectMeta.java

  Line 53 in 13387c7

  private String creationTimestamp;

• kubernetes-client/kubernetes-model-generator/kubernetes-model-storageclass/src/generated/java/io/fabric8/kubernetes/api/model/storage/VolumeError.java

  Line 56 in 13387c7

  private String time;

• kubernetes-client/kubernetes-model-generator/kubernetes-model-apps/src/generated/java/io/fabric8/kubernetes/api/model/apps/DeploymentCondition.java

  Line 58 in 13387c7

  private String lastTransitionTime;

[rohanKanojia]

I think it would be better if we have a new issue for addressing this.

[manusa]

I think it would be better if we have a new issue for addressing this.

Indeed, a new issue should be open to keep track of this and properly plan its implementation.

[sonarqubecloud]

SonarCloud Quality Gate failed.   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

78.9% Coverage
0.0% Duplication

[LiamClarkeNZ]

As we discussed after today's stand-up, it would be much better if these fields that represent time were typed as OffsetDateTime , or any other type that properly represents timestamps with timezone information.

@manusa as an end user, that would be nice, it would make it easier to not get it wrong, especially when the K8s documentation isn't overly explicit about accepted formats. :)