Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chore: Update Knative Serving and Eventing Model to v0.23.0 #3196

Merged
merged 1 commit into from
Jun 3, 2021
Merged

Chore: Update Knative Serving and Eventing Model to v0.23.0 #3196

merged 1 commit into from
Jun 3, 2021

Conversation

rohanKanojia
Copy link
Member

@rohanKanojia rohanKanojia commented May 31, 2021 •
edited by manusa
Loading

Description

Fix #2741

  • Update Knative Service+Eventing model to v0.23.0
  • Knative serving v1beta1 removed from Knative serving API hence removal of serving v1beta1 DSL classes
  • Knative source api seems to be moved from v1beta1 to v1

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change
  • Chore (non-breaking change which doesn't affect codebase;
    test, version modification, documentation, etc.)

Checklist

  • Code contributed by me aligns with current project license: Apache 2.0
  • I Added CHANGELOG entry regarding this change
  • I have implemented unit tests to cover my changes
  • I have added/updated the javadocs and other documentation accordingly
  • No new bugs, code smells, etc. in SonarCloud report
  • I tested my code in Kubernetes
  • I tested my code in OpenShift

@rohanKanojia
Chore: Update Knative Model to v0.23.0
989d3d6 
+ Knative serving v1beta1 removed from [Knative serving
  API](https://github.com/knative/serving/tree/v0.23.0/pkg/apis/serving)
  hence removal of serving v1beta1 DSL classes
+ Knative source api seems to be moved from v1beta1 to v1
@rohanKanojia rohanKanojia force-pushed the pr/chore-knative-bump-0-23-0 branch from 5fe67f2 to 989d3d6 Compare June 2, 2021 18:23
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jun 2, 2021

SonarCloud Quality Gate failed.

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

manusa
manusa approved these changes Jun 3, 2021
View reviewed changes
Copy link
Member

@manusa manusa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thx!

@manusa manusa merged commit 4196bff into fabric8io:master Jun 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manusa manusa manusa approved these changes

@oscerd oscerd oscerd approved these changes

Assignees

@rohanKanojia rohanKanojia

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update Knative Model to v0.23.0
3 participants
@rohanKanojia @manusa @oscerd