fix #3090 #3091 refining the store interface and hasSynced #3167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
oscerd
approved these changes
May 25, 2021
shawkins
force-pushed
the
remove-df-after-cache
branch
from
975c377 to
65e3e5f
Compare
…sSynced splitting internal and mutative methods to SyncableStore removing isPopulated and directly wiring the cache to be used this adds an isRunning method to the SharedInformer. this clarifies the cache methods to be more like a map and the underlying map is now concurrent to remove read locks
shawkins
force-pushed
the
remove-df-after-cache
branch
from
65e3e5f to
57ba9f6
Compare
kubernetes-client/src/main/java/io/fabric8/kubernetes/client/informers/cache/Cache.java
Outdated
Show resolved
Hide resolved
kubernetes-client/src/main/java/io/fabric8/kubernetes/client/informers/cache/Cache.java
Show resolved
Hide resolved
shawkins
force-pushed
the
remove-df-after-cache
branch
from
684f99f to
7448742
Compare
|
SonarCloud Quality Gate failed. |
|
Relates to: #2010 |
rohanKanojia
approved these changes
Jun 9, 2021
manusa
reviewed
Jun 9, 2021
kubernetes-client/src/main/java/io/fabric8/kubernetes/client/informers/cache/Cache.java
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Refining the Store interface by splitting internal and mutative methods to SyncableStore
Removing isPopulated and directly wiring the cache to be used
this adds an isRunning method to the SharedInformer. this clarifies the
cache methods to be more like a map and the underlying map is now
concurrent to remove read locks
This could be seen as a breaking change since Store is somewhat of a public interface - however it seems much clearer and safer to have a narrower interface.
Closes #3013
Type of change
test, version modification, documentation, etc.)
Checklist