Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #3159: simplifying the resync logic #3165

Closed
wants to merge 1 commit into from

Conversation

shawkins
Copy link
Contributor

Description

This treats the informer resync period as the only meaningful resync interval. It is however a breaking change and does diverge from the go client.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change
  • Chore (non-breaking change which doesn't affect codebase;
    test, version modification, documentation, etc.)

Checklist

  • Code contributed by me aligns with current project license: Apache 2.0
  • I Added CHANGELOG entry regarding this change
  • I have implemented unit tests to cover my changes
  • I have added/updated the javadocs and other documentation accordingly
  • No new bugs, code smells, etc. in SonarCloud report
  • I tested my code in Kubernetes
  • I tested my code in OpenShift

treats the informer resync period as the only meaningful resync
@centos-ci
Copy link

Can one of the admins verify this patch?

@sonarqubecloud
Copy link

@shawkins
Copy link
Contributor Author

After better understanding the expectations from the go code, this is too much of a breaking change.

@shawkins shawkins closed this May 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants