fix: #3050 adding more enforcement of the informer lifecycle #3056
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
oscerd
approved these changes
Apr 28, 2021
also removing the empty string return for last version when not started - it complicates checking the last resource version as you have to look for null and empty string to check for invalid values.
manusa
force-pushed
the
informer-lifecycle
branch
from
ca3c363 to
35707a6
Compare
|
SonarCloud Quality Gate failed. |
manusa
reviewed
Apr 30, 2021
...nt/src/main/java/io/fabric8/kubernetes/client/informers/impl/DefaultSharedIndexInformer.java
Show resolved
Hide resolved
|
Relates to: #2010 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adding more checks around the informer lifecycle.
Also removing the empty string return for last version when not started - it complicates checking the last resource version as you have to look for null and empty string to check for invalid values.
Type of change
test, version modification, documentation, etc.)
Checklist