allowing the auto-reconnect logic to work after an onClose exception #3018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
manusa
reviewed
Apr 21, 2021
kubernetes-client/src/main/java/io/fabric8/kubernetes/client/Watcher.java
Show resolved
Hide resolved
oscerd
approved these changes
Apr 21, 2021
rohanKanojia
force-pushed
the
informer-reconnect
branch
from
4f0e1c3 to
3ae2b55
Compare
rohanKanojia
approved these changes
Apr 21, 2021
manusa
force-pushed
the
informer-reconnect
branch
from
7a2b4f3 to
b2ad62e
Compare
|
SonarCloud Quality Gate failed. |
This was referenced Apr 22, 2021
Closed
shawkins
added a commit
to shawkins/kubernetes-client
that referenced
this pull request
Apr 27, 2021
this incorporates the reflector changes from fabric8io#3029 It goes further in refining responsibilities by mostly relying on the watch for tracking the lastResourceVersion and removing onClose behavior that is no longer necessary due to fabric8io#3018
This was referenced Apr 27, 2021
|
Relates to: #2010 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As seen in #2992 if there is a failure with the shared informer watch, and then an exception thrown from the ReflectorWatcher.onClose(WatcherException) method, the watch is effectively terminated.
Related to this, there isn't a great way from the available apis to determine when a index informer has failed.
Fix #2992
Type of change
Checklist