cleaning up the reflectorwatcher logging #2993
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
rohanKanojia
approved these changes
Apr 14, 2021
|
@shawkins : Shall we move this to debug as well? |
|
@rohanKanojia normal close seems infrequent enough to be at the info level, but I'm fine at a debug as well. |
|
ohk, let's keep it as it is then. |
oscerd
approved these changes
Apr 14, 2021
hanikesn
reviewed
Apr 15, 2021
...etes-client/src/main/java/io/fabric8/kubernetes/client/informers/cache/ReflectorWatcher.java
Outdated
Show resolved
Hide resolved
shawkins
changed the title
shawkins
changed the title
shawkins
added a commit
to shawkins/kubernetes-client
that referenced
this pull request
Apr 17, 2021
also moves the responsibility for the lastResourceVersion to the DeltaFIFO - having it updatable outside the DeltaFIFO lock is dangerous this does not include the changes for fabric8io#2993 nor fabric8io#2995
shawkins
added a commit
to shawkins/kubernetes-client
that referenced
this pull request
Apr 17, 2021
also moves the responsibility for the lastResourceVersion to the DeltaFIFO - having it updatable outside the DeltaFIFO lock is dangerous this does not include the changes for fabric8io#2993 nor fabric8io#2995
This was referenced Apr 17, 2021
|
Kudos, SonarCloud Quality Gate passed! |
|
@rohanKanojia is it possible to get this in 5.3.1? |
This was referenced May 5, 2021
|
Relates to: #2010 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix for #2991 - event received logged at too high of a level.
Type of change
Checklist