Update Kubernetes Model to v1.21.0 #2979
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oscerd
approved these changes
Apr 9, 2021
rohanKanojia
force-pushed
the
kubernetes-model-1-21-1
branch
4 times, most recently
from
73e8fda to
74e8d9f
Compare
manusa
reviewed
Apr 13, 2021
Comment on lines
41
to
47
| public MixedOperation<Job, JobList, ScalableResource<Job>> jobs() { | ||
| return new JobOperationsImpl(httpClient, getConfiguration()); | ||
| public V1BatchAPIGroupDSL v1() { | ||
| return adapt(V1BatchAPIGroupClient.class); | ||
| } | ||
|
|
||
| @Override | ||
| public MixedOperation<CronJob, CronJobList, Resource<CronJob>> cronjobs() { | ||
| return new CronJobOperationsImpl(httpClient, getConfiguration()); |
There was a problem hiding this comment.
Could we keep this as @Deprecated+@deprecated and point to the old V1beta1BatchAPIGroupClient cronjobs and jobs?
This way changes won't be that breaking.
There was a problem hiding this comment.
I don't know how you reverted these changes, but you reverted the examples too (not sure if that was on purpose).
I do think that examples should use the new non-deprecated APIs
manusa
reviewed
Apr 13, 2021
| public MixedOperation<PodDisruptionBudget, PodDisruptionBudgetList, Resource<PodDisruptionBudget>> podDisruptionBudget() { | ||
| return new PodDisruptionBudgetOperationsImpl(httpClient, getConfiguration()); | ||
| public V1beta1PolicyAPIGroupDSL v1beta1() { | ||
| return adapt(V1beta1PolicyAPIGroupClient.class); | ||
| } |
There was a problem hiding this comment.
rohanKanojia
force-pushed
the
kubernetes-model-1-21-1
branch
2 times, most recently
from
420e0cc to
926ba43
Compare
+ Update Kubernetes Model Schema as per Kubernetes v1.21.0
+ Added `client.batch().v1()` and `client.batch().v1beta1()` DSL + Added `client.policy().v1()` and `client.policy().v1beta1()` DSL + Added `client.discovery.v1()` DSL
This commit reverts removal of the following DSLs: - `client.batch().jobs()` - `client.batch().cronjobs()` - `client.policy().podSecurityPolicies()` - `client.policy().podDisruptionBudget()`
rohanKanojia
force-pushed
the
kubernetes-model-1-21-1
branch
from
926ba43 to
9e50cf4
Compare
|
SonarCloud Quality Gate failed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
https://kubernetes.io/blog/2021/04/08/kubernetes-1-21-release-announcement/
DSL Changes:
client.batch().jobs()deprecatedclient.batch().cronjobs()deprecatedclient.policy().podSecurityPolicies()deprecatedclient.policy().podDisruptionBudget()deprecatedModel Changes:
io.fabric8.kubernetes.api.model.batchhave been moved toio.fabric8.kubernetes.api.model.batch.v1andio.fabric8.kubernetes.api.model.batch.v1beta1io.fabric8.kubernetes.api.model.policyhave been moved toio.fabric8.kubernetes.api.model.policy.v1andio.fabric8.kubernetes.api.model.policy.v1beta1io.fabric8.kubernetes.api.model.discovery.v1EndpointSliceType of change
test, version modification, documentation, etc.)
Checklist