Refactored and updated according to kubernetes 1.9 and openshift 3.9 #1103
Conversation
|
So all the client work has been done, now we need to release model to reflect here and all tests(unit and rt) passed on my local system. |
There was a problem hiding this comment.
This is huge work @piyush1594. Thank you for it 👍
Could you please add regression test with OpenShift 3.9 and update the compatibility matrix.
|
@hrishin Upgraded with openshift 3.9.0 RT job and also latest released Kubernetes-Model 3.0.0 🎉 |
|
@piyush1594 @rohanKanojia what shall we do for OS 3.6, 3.7 RT's? |
|
@piyush1594 could you please update the compatibility table? |
|
Thanks @iocanel, will update the compatibility matrix and docs after CI get passes. |
|
@hrishin Updated the compatibility matrix and also added docs regarding the major changes. |
| } | ||
|
|
||
| @Test | ||
| public void load() { | ||
| Deployment aDeployment = client.extensions().deployments().inNamespace(currentNamespace).load(getClass().getResourceAsStream("/test-deployments.yml")).get(); | ||
| Deployment aDeployment = client.apps().deployments().inNamespace(currentNamespace).load(getClass().getResourceAsStream("/test-deployments.yml")).get(); |
There was a problem hiding this comment.
can we also ensure about client.extensions()? one use case is sufficient
| @@ -74,13 +79,13 @@ public void init(){ | |||
| .endSpec() | |||
| .build(); | |||
|
|
|||
| client.extensions().networkPolicies().create(networkPolicy); | |||
| client.network().networkPolicies().create(networkPolicy); | |||
There was a problem hiding this comment.
can we also ensure about client.extensions()? one use case is sufficient
|
@piyush1594 @hrishin: This is a major blocker for us and I'd like to have this merged as soon as possible. Please let me know if there are things I can do to help with this PR. Also, does anyone know why tests in CircleCI 3.6.0, 3.6.1, 3.7.0 take so long to run? |
|
What's the situation with 3.9 and 1.9 support? |
images in container to run test smoothly and fast
…duling in failing
and also lessing down replicas in replica set Replica down to 1
|
Thanks @piyush1594 !!! |
Fixes #1020