Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove model properties #4515

Closed
shawkins opened this issue Oct 20, 2022 · 6 comments · Fixed by #4511
Closed

Remove model properties #4515

shawkins opened this issue Oct 20, 2022 · 6 comments · Fixed by #4511
Milestone
6.3.0

Comments

@shawkins
Copy link
Contributor 

    It's been so long that I can't really recall the need for model properties. I would assume though that it was added to serve code generation purposes in the client. Possibly, at some point it was needed to generate `ResourceHandlers` or `OperationImpl`.

Originally posted by @iocanel in #4511 (comment)
@shawkins
Copy link
Contributor Author

cc @rohanKanojia @manusa any object to removing the legacy model.properties files? We will still need the manifest.vm if we move forward with #4511

@manusa
Copy link
Member

manusa commented Nov 4, 2022

please go ahead

@manusa manusa added this to the 6.3.0 milestone Nov 4, 2022
@shawkins
Copy link
Contributor Author

shawkins commented Nov 4, 2022

Let's first decide on #4511

@manusa
Copy link
Member

manusa commented Nov 4, 2022

Let's first decide on #4511

Noted. For some reason I'm reviewing my pending tasks/emails/notifications in a very random order 😅

@manusa
Copy link
Member

manusa commented Nov 15, 2022

Since we seem to agree that #4511 is the way to go forward with the KubernetesDeserializer, we should close this issue now.

shawkins added a commit to shawkins/kubernetes-client that referenced this issue Nov 16, 2022
@shawkins
fix fabric8io#4515: removing the legacy usage of model.properties
ff91f33
shawkins added a commit to shawkins/kubernetes-client that referenced this issue Nov 16, 2022
@shawkins
fix fabric8io#4515: removing the legacy usage of model.properties
380e9d8
shawkins added a commit to shawkins/kubernetes-client that referenced this issue Nov 16, 2022
@shawkins
fix fabric8io#4515: regenerating the models
5a343cb
@shawkins
Copy link
Contributor Author

@manusa I've updated #4511 with changes for this.

@manusa manusa mentioned this issue Nov 21, 2022
Merged
11 tasks
manusa pushed a commit that referenced this issue Nov 21, 2022
@shawkins @manusa
fix #4515: removing the legacy usage of model.properties
1f8e3fe
manusa pushed a commit that referenced this issue Nov 21, 2022
@shawkins @manusa
fix #4515: regenerating the models
789cce9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
6.3.0
Development

Successfully merging a pull request may close this issue.

KubernetesDeserializer class resolving with SPI shawkins/kubernetes-client
2 participants
@manusa @shawkins