Fix #2717: Remove edit() methods from RawCustomResourceOperationsImpl…

… taking InputStream arguments

As discussed in #2717, it's not a good idea to take InputStream for
edit() methods which simply does a PATCH to Kubernetes APIServer.

CHANGELOG.md

@@ -6,6 +6,7 @@
 * Fix #2748: Pass custom headers in kubernetes-client to watch api by modify WatchConnectionManager
 
 #### Improvements
+* Fix #2717: Remove edit() methods from RawCustomResourceOperationsImpl taking InputStream arguments
 
 #### Dependency Upgrade
 * update Tekton Triggers model to v0.11.1

kubernetes-client/src/main/java/io/fabric8/kubernetes/client/dsl/internal/RawCustomResourceOperationsImpl.java

@@ -286,31 +286,6 @@ public Map<String, Object> edit(String namespace, String name, String objectAsSt
     return validateAndSubmitRequest(namespace, name, objectAsString, HttpCallMethod.PUT);
   }
 
-  /**
-   * Edit a custom resource object which is a non-namespaced object.
-   *
-   * @param name name of the custom resource
-   * @param objectAsStream new object as a file input stream
-   * @return Object as HashMap
-   * @throws IOException in case of network/serialization failures or failures from Kubernetes API
-   */
-  public Map<String, Object> edit(String name, InputStream objectAsStream) throws IOException {
-    return validateAndSubmitRequest(null, name, IOHelpers.readFully(objectAsStream), HttpCallMethod.PUT);
-  }
-
-  /**
-   * Edit a custom resource object which is a namespaced object.
-   *
-   * @param namespace desired namespace
-   * @param name name of the custom resource
-   * @param objectAsStream new object as a file input stream
-   * @return Object as HashMap
-   * @throws IOException in case of network/serialization failures or failures from Kubernetes API
-   */
-  public Map<String, Object> edit(String namespace, String name, InputStream objectAsStream) throws IOException {
-    return validateAndSubmitRequest(namespace, name, IOHelpers.readFully(objectAsStream), HttpCallMethod.PUT);
-  }
-
   /**
    * Update status related to a CustomResource, this method does a PUT request on /status endpoint related
    * to the CustomResource

kubernetes-itests/src/test/java/io/fabric8/kubernetes/RawCustomResourceIT.java

@@ -151,7 +151,7 @@ public void testCrudUsingMap() throws IOException {
   }
 
   @Test
-  public void testCrudUsingInputStream() throws IOException {
+  public void testCreateReadDeleteUsingInputStream() throws IOException {
     // Create
     String name = "hippo";
     InputStream hippoInputStream = getClass().getResourceAsStream("/rawcustomresourceit-crud-inputstream.yml");
@@ -162,13 +162,6 @@ public void testCrudUsingInputStream() throws IOException {
     hippoCr = client.customResource(customResourceDefinitionContext).get(currentNamespace, name);
     assertAnimal(hippoCr, name, "Hippopotamidae");
 
-    // Update
-    ((Map<String, Object>)hippoCr.get("spec")).put("image", "river-hippo");
-    File updatedHippoManifest = Files.createTempFile("hippo", "yml").toFile();
-    FileUtils.writeStringToFile(updatedHippoManifest, Serialization.jsonMapper().writeValueAsString(hippoCr));
-    hippoCr = client.customResource(customResourceDefinitionContext).edit(currentNamespace, name, new FileInputStream(updatedHippoManifest));
-    assertAnimal(hippoCr, name, "river-hippo");
-
     // Delete
     Map<String, Object> deletionStatusMap = client.customResource(customResourceDefinitionContext).delete(currentNamespace, name);
     assertDeletionStatus(deletionStatusMap, "Success");