forked from openshift/jenkins-sync-plugin
-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Get rid of job-to-bc branch and make master branch as source of truth #18
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…igured jobNamePattern
…set on the property and only inserting/updating valid pipeline jobs with a jenkinsfile/path
…ok for files that match Jenkinsfile so no need to set optional BC value
…he generated BuildConfigs don't generate new Jobs via the BuildWatcher
# Conflicts: # src/main/java/io/fabric8/jenkins/openshiftsync/BuildConfigToJobMapper.java
…uffix by default for the generated BuildConfig names
…us fullPath logic and allow BCs to be annotated to avoid creating a linked jenkins job
…reated via openshift look nice and clean inside Jenkins
…namespace to watch
…e Proceed/Abort stuff if they want
so we can use off the shelf releases of workflow-multibranch without needing a PR merged etc
if users delete a BC it would be nice to remove it from the parent github org folder plugin's pattern too if its there; to avoid it coming back again. fixes openshift#141
…f there's an env var set
with a build.openshift.io API Group defined to sync pipeline jobs to BuildConfig and Build resources
for non-pipeline jobs lets support the creation of Jenkins jobs from ConfigMap resources labelled correctly that store the config.xml in the ConfigMap data. This lets us create jobs like the github org job via the kubernetes REST API without requiring access to a Jenkins master for openshift.io/fabric8. One day we could have a new BuildConfig kind in openshift and we could migrate to using that; but until then this simple approach allows us to use ConfigMaps for arbitrary jenkins jobs which are not pipelines
upgrade kubernetes-client
- added more logging for creating watch request - updated kubernetes client to 3.1.5 - increased polling interval from 10 seconds to 3-5 minutes
Temp fix for watchers issues
- added find bug - updated dependecy versions
1. With introduction of Jenkins ideler/proxy have to fix the console URL generation With that higher precedence is given to ENV VAR (JENKINS_ROOT_URL) having proxy URL, otherwise, URL of Jenkins service if it does exist in OpenShift. This issue is fixed in BuildSyncRunListener.java 2. Added the unit test for this fix : BuildSyncRunListenerTest.java 3. Fixed test execution issue : Upgraded <artifactId>credentials</artifactId> dependency version 4. Updated README.md with this URL configuration section
- increasted buildsync default polling time from 1 seconds to 5 seconds - updated README.md for this change
Sorry I don't have time to maintain or review anything on this project any more. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #17