This repository has been archived by the owner on Jun 19, 2024. It is now read-only.
Bugfix/#1751 openshift docker s2i #1753
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
manusa
commented
Nov 7, 2019
manusa
commented
- Implemented behavior described in Build Names are suffixed with -*s2i regardless of build strategy #1751 (comment)
- Refactored tests, now tests will fail if the number of retries exceeds the predefined limit.
- Implemented new tests to verify the current implementation
Codecov Report
@@ Coverage Diff @@
## master #1753 +/- ##
============================================
+ Coverage 35.42% 35.45% +0.02%
- Complexity 1171 1173 +2
============================================
Files 191 191
Lines 10928 10933 +5
Branches 1771 1773 +2
============================================
+ Hits 3871 3876 +5
Misses 6595 6595
Partials 462 462 |
rohanKanojia
approved these changes
Nov 7, 2019
rohanKanojia
added
jkube/pending
rohanKanojia
pushed a commit
to eclipse-jkube/jkube
that referenced
this pull request
Nov 29, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.