Skip to content
This repository has been archived by the owner on Jun 19, 2024. It is now read-only.

Support integer keys in application.yaml #1746

Merged
merged 3 commits into from
Nov 4, 2019
Merged

Support integer keys in application.yaml #1746

merged 3 commits into from
Nov 4, 2019

Conversation

schuch
Copy link
Contributor

@schuch schuch commented Oct 25, 2019

Fix for #1695

@codecov
Copy link

codecov bot commented Oct 25, 2019

Codecov Report

Merging #1746 into master will increase coverage by 0.01%.
The diff coverage is 88.88%.

@@             Coverage Diff              @@
##             master    #1746      +/-   ##
============================================
+ Coverage     34.38%   34.39%   +0.01%     
- Complexity     1128     1129       +1     
============================================
  Files           190      190              
  Lines         10827    10829       +2     
  Branches       1761     1762       +1     
============================================
+ Hits           3723     3725       +2     
  Misses         6661     6661              
  Partials        443      443

Copy link
Member

@rohanKanojia rohanKanojia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good, Thanks 👍 . I would look closely into it next week.

Could you please add a line to CHANGELOG.md regarding the change in the meantime?

@schuch
Copy link
Contributor Author

schuch commented Oct 27, 2019

Could you please add a line to CHANGELOG.md regarding the change in the meantime?

will do 👍

@rohanKanojia rohanKanojia requested a review from manusa November 4, 2019 10:30
@devang-gaur devang-gaur merged commit 77ccfe8 into fabric8io:master Nov 4, 2019
@rohanKanojia rohanKanojia added the jkube/pending The issue/PR has to be taken care of in JKube https://github.com/eclipse/jkube label Nov 5, 2019
rohanKanojia added a commit to rohanKanojia/jkube that referenced this pull request Nov 7, 2019
+ spring-boot generator can not handle multi-profile configration

Ported PR fabric8io/fabric8-maven-plugin#1745
Ported PR fabric8io/fabric8-maven-plugin#1746
@rohanKanojia rohanKanojia removed the jkube/pending The issue/PR has to be taken care of in JKube https://github.com/eclipse/jkube label Nov 7, 2019
rohanKanojia added a commit to eclipse-jkube/jkube that referenced this pull request Nov 29, 2019
+ spring-boot generator can not handle multi-profile configration

Ported PR fabric8io/fabric8-maven-plugin#1745
Ported PR fabric8io/fabric8-maven-plugin#1746
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants