This repository has been archived by the owner on Jun 19, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 202
Support integer keys in application.yaml #1746
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1746 +/- ##
============================================
+ Coverage 34.38% 34.39% +0.01%
- Complexity 1128 1129 +1
============================================
Files 190 190
Lines 10827 10829 +2
Branches 1761 1762 +1
============================================
+ Hits 3723 3725 +2
Misses 6661 6661
Partials 443 443 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good, Thanks 👍 . I would look closely into it next week.
Could you please add a line to CHANGELOG.md regarding the change in the meantime?
will do 👍 |
rohanKanojia
approved these changes
Nov 4, 2019
devang-gaur
approved these changes
Nov 4, 2019
rohanKanojia
added
the
jkube/pending
The issue/PR has to be taken care of in JKube https://github.com/eclipse/jkube
label
Nov 5, 2019
rohanKanojia
added a commit
to rohanKanojia/jkube
that referenced
this pull request
Nov 7, 2019
+ spring-boot generator can not handle multi-profile configration Ported PR fabric8io/fabric8-maven-plugin#1745 Ported PR fabric8io/fabric8-maven-plugin#1746
rohanKanojia
removed
the
jkube/pending
The issue/PR has to be taken care of in JKube https://github.com/eclipse/jkube
label
Nov 7, 2019
rohanKanojia
added a commit
to eclipse-jkube/jkube
that referenced
this pull request
Nov 29, 2019
+ spring-boot generator can not handle multi-profile configration Ported PR fabric8io/fabric8-maven-plugin#1745 Ported PR fabric8io/fabric8-maven-plugin#1746
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #1695