This repository has been archived by the owner on Jun 19, 2024. It is now read-only.
Chore: Remove enrichAll flag from ImageChangeTriggerEnricher config #1638
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rohanKanojia
force-pushed
the
pr/removeImageChangeTriggerFlag
branch
from
2dca34d to
c9285f4
Compare
lordofthejars
suggested changes
May 23, 2019
| @@ -225,6 +225,9 @@ | |||
| @Parameter(property = "fabric8.namespace") | |||
| private String namespace; | |||
|
|
|||
| @Parameter(property = "fabric8.sidecar") | |||
| private String sidecar; | |||
There was a problem hiding this comment.
It should be a boolean with default to false instead of String and parse it later.
rohanKanojia
force-pushed
the
pr/removeImageChangeTriggerFlag
branch
from
ebc9c89 to
1bad3dc
Compare
rohanKanojia
force-pushed
the
pr/removeImageChangeTriggerFlag
branch
from
1bad3dc to
eab6fbf
Compare
rohanKanojia
force-pushed
the
pr/removeImageChangeTriggerFlag
branch
from
eab6fbf to
6a71c37
Compare
lordofthejars
approved these changes
Jun 13, 2019
rohanKanojia
added a commit
to rohanKanojia/jshift-kit
that referenced
this pull request
Jun 13, 2019
rohanKanojia
added a commit
to rohanKanojia/kubernetes-maven-plugin
that referenced
this pull request
Jun 13, 2019
lordofthejars
pushed a commit
to jshiftio/jshift-kit
that referenced
this pull request
Jun 13, 2019
lordofthejars
pushed a commit
to jshiftio/kubernetes-maven-plugin
that referenced
this pull request
Jun 13, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After discussion with @mojsha about the problems he is facing, I'm removing this parameter from Enricher config and adding it like a mojo parameter. Somehow maven doesn't recognize it when parameter contains "-" in the name.